Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters defaults etc #85

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Parameters defaults etc #85

merged 6 commits into from
Sep 4, 2024

Conversation

cmbant
Copy link
Collaborator

@cmbant cmbant commented Jul 29, 2024

Building on other PRs (i.e. just last commit for PR-specific changes), and trying to make a bit closer to SOlikeT version, I reorganised some of the parameter handling. A lot of the testing should I think be done by Cobaya, so should still get error messages etc if something is wrong.

This separates out loglike() as a separate (non-Cobaya) function, but avoids duplication of all the parameter names in the yaml and code.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.95238% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@660e0fa). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #85   +/-   ##
=========================================
  Coverage          ?   82.50%           
=========================================
  Files             ?        3           
  Lines             ?      383           
  Branches          ?        0           
=========================================
  Hits              ?      316           
  Misses            ?       67           
  Partials          ?        0           
Files Coverage Δ
mflike/mflike.py 89.47% <96.42%> (ø)
mflike/theoryforge.py 75.80% <68.57%> (ø)

@cmbant cmbant merged commit 33c61f8 into master Sep 4, 2024
11 checks passed
@cmbant cmbant deleted the defparams branch September 4, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants